#17 Division by zero is not prevented

Severity

Low Risk

Relevant GitHub Links

https://github.com/Cyfrin/2023-12-the-standard/blob/91132936cb09ef9bf82f38ab1106346e2ad60f91/contracts/LiquidationPool.sol#L220-L221

Summary

Division by zero is not prevented

Vulnerability Details

The divisions below take an input parameter that has no zero-value checks, which can cause the functions reverting if zero is passed.

File: contracts/LiquidationPool.sol

/// @audit `_collateralRate`
220:                         uint256 costInEuros = _portion * 10 ** (18 - asset.token.dec) * uint256(assetPriceUsd) / uint256(priceEurUsd)

Github: [220]

Impact

See Vulnerability Details

Tools Used

Manual Review

Recommendations

Consider checking if _collateralRate is zero.