gas

Underscore function arguments

Reward

Total

24.49 USDC

Selected
24.49 USDC
Selected Submission

Underscore function arguments

Severity

Gas Optimization / Informational

Relevant GitHub Links

https://github.com/Cyfrin/2023-07-foundry-defi-stablecoin/blob/main/src/DSCEngine.sol

https://github.com/Cyfrin/2023-07-foundry-defi-stablecoin/blob/main/src/DecentralizedStableCoin.sol

Summary

Lack consistency function arguments structure e.g underscores _

Vulnerability Details

DSCEngine.sol does not use underscore _ e.g _to, _amount function arguments however DecentralizedStableCoin.sol has that format instead

Impact

Informational: This leads to inconsistency in code affecting code quality

Tools Used

Manual Analysis

Recommendations

It is recommended to be consistent and prefer _ to all function arguments across all relevant functions of all relevant contracts in project. If underscore not desired then ensure contracts follow same style and do not use them.