low

Lack of events for critical actions

Reward

Total

11.01 USDC

1.17 USDC
1.17 USDC
1.17 USDC
1.17 USDC
1.17 USDC
1.17 USDC
Selected
1.64 USDC
1.17 USDC
1.17 USDC
Selected Submission

Lack of events for critical actions

Severity

Low Risk

Relevant GitHub Links

https://github.com/Cyfrin/2023-07-foundry-defi-stablecoin/blob/d1c5501aa79320ca0aeaa73f47f0dbc88c7b77e2/src/DSCEngine.sol#L229

https://github.com/Cyfrin/2023-07-foundry-defi-stablecoin/blob/d1c5501aa79320ca0aeaa73f47f0dbc88c7b77e2/src/DSCEngine.sol#L212

https://github.com/Cyfrin/2023-07-foundry-defi-stablecoin/blob/d1c5501aa79320ca0aeaa73f47f0dbc88c7b77e2/src/DSCEngine.sol#L197

Summary

The functions mintDsc, burnDsc and liquidate do not emit any events.

Vulnerability Details

Event logs are crucial for off-chain services as they notify external users, such as a listening frontend website or client application, that something has happened on the blockchain.

Impact

External users and blockchain monitoring systems will not be able to easily detect these critical functions and their changes without events.

Tools Used

Manual Analysis

Recommendations

Add events where possible for critical operations.